Skip to content

Adopt .apollo.method() namespacing for extensions#1256

Merged
designatednerd merged 17 commits intomasterfrom
update/namespacing
Jun 12, 2020
Merged

Adopt .apollo.method() namespacing for extensions#1256
designatednerd merged 17 commits intomasterfrom
update/namespacing

Conversation

@designatednerd
Copy link
Copy Markdown
Contributor

@designatednerd designatednerd commented Jun 12, 2020

This PR:

  • moves us to more consistent usage of the apollo.blah() way of sending extension methods through a namespace. This requires some silliness with Protocols With Associated Types for a couple things involving generics, but I think the consistency is worth it.
  • Adds some more readable extension methods on URLs. I plan to update the Swift Codegen setup with this once it's merged, since it makes things a LOT clearer.
  • Moves a couple things, including Atomic, to ApolloCore. This is mostly going to serve as a check that migrating more things to core isn't going to break everything for now, but I plan to move more stuff not necessary outside of reading in code-generated files into Core to help deal with Generated types import the entire Apollo runtime #1047

@designatednerd designatednerd merged commit b66f99d into master Jun 12, 2020
@designatednerd designatednerd deleted the update/namespacing branch June 12, 2020 13:46
@designatednerd designatednerd added this to the Next Release milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant